eslint-community/eslint-plugin-promise

feature: warn when calling async functions without an await (no floating promises)

Open

#151 opened on Nov 7, 2018

View on GitHubContributor guide
 (13 comments) (4 reactions) (0 assignees)JavaScript (103 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (998 stars)
PR merge metrics
 (Avg merge 1d 2h) (12 merged PRs in 30d)

Description

Forgetting to put an await before calling an async function can have very bad outcomes and is quite hard to notice

TSLint has a rule named no-floating-promises -https://palantir.github.io/tslint/rules/no-floating-promises/

Can you implement a similar rule in this ESLint plugin?

Contributor guide

Research direction
Study the TSLint no floating promises rule implementation and examine the eslint plugin promise codebase to understand how other rules (e.g., no return wrap) are structured. Then implement an AST visitor that detects call expressions to async functions without an await.
Tech stack
javascript
Domain
backendtoolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60