erming/shout

URLs ending with a close parentheses are not linked properly

Open

#255 opened on Oct 22, 2014

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (3,640 stars) (293 forks)batch import
bughelp wanted

Description

Not if there are other characters that have this occur, but I noticed it with this url:

image

http://en.wikipedia.org/wiki/The_Martian_(Andy_Weir)

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontendbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptregular expressions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is that URLs containing parentheses, like Wikipedia links, are not properly linked because the parentheses are not escaped or the URL detection regex does not account for them. To fix, examine the URL parsing logic in shout's source code, likely in a file that handles message rendering or linkification. Look for a regex pattern that extracts URLs and modify it to handle balanced parentheses, or use a library like 'url regex' that handles this. Test with the given example URL. There may be existing comments or PRs for reference.