erikringsmuth/app-router

Core-animated-pages inside pages

Open

#69 opened on Jan 22, 2015

View on GitHub
 (6 comments) (0 reactions) (0 assignees)HTML (83 forks)batch import
bughelp wanted

Repository metrics

Stars
 (608 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, I am using app-router with animation between routes. In some of my pages I have core-animated-pages element that animates the content inside. The problem is that when the inner transition ends, app-router catches this event and then removes whole page.

Line 80 in app-router.js

// when a transition finishes, remove the previous route's content. there is a temporary overlap where both
// the new and old route's content is in the DOM to animate the transition.
router.coreAnimatedPages.addEventListener('core-animated-pages-transition-end', function() {
      transitionAnimationEnd(router.previousRoute);
});

Is it possible to use core-animated pages inside page routes with core-animated-pages enabled on router?

Contributor guide