erikringsmuth/app-router

Core-animated-pages inside pages

Open

#69 opened on Jan 22, 2015

View on GitHub
 (6 comments) (0 reactions) (0 assignees)HTML (608 stars) (83 forks)batch import
bughelp wanted

Description

Hi, I am using app-router with animation between routes. In some of my pages I have core-animated-pages element that animates the content inside. The problem is that when the inner transition ends, app-router catches this event and then removes whole page.

Line 80 in app-router.js

// when a transition finishes, remove the previous route's content. there is a temporary overlap where both
// the new and old route's content is in the DOM to animate the transition.
router.coreAnimatedPages.addEventListener('core-animated-pages-transition-end', function() {
      transitionAnimationEnd(router.previousRoute);
});

Is it possible to use core-animated pages inside page routes with core-animated-pages enabled on router?

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript event handlingWeb Components basicsPolymer core animated pages
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the event listener on line 80 of app router.js that captures 'core animated pages transition end'. Determine how to differentiate between transitions from the outer router and inner pages. Consider using event.stopPropagation() or checking the event target to ignore inner transitions. Look at existing comments and any attempts to fix this issue.