erikringsmuth/app-router

core-animated-pages multiple paths match same app-route

Open

#44 opened on Dec 5, 2014

View on GitHub
 (3 comments) (0 reactions) (0 assignees)HTML (83 forks)batch import
bugdesign discussionhelp wanted

Repository metrics

Stars
 (608 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This is an extension of PR https://github.com/erikringsmuth/app-router/pull/43 from @sohjsolwin.

Example router.

<app-router core-animated-pages transitions="cross-fade-all">
  <app-route path="/first" element="first-page"></app-route>
  <app-route path="/second" element="second-page"></app-route>
  <app-route path="/page/:pageNum" element="third-page"></app-route>
</app-router>

Paths /page/1 and /page/2 will both match the last route. The transition between these two pages won't be animated because setting coreAnimatedPages.selected = 3 doesn't change the page.

This may require a big re-think of the app-router / core-animated-pages implementation...

Contributor guide

Research direction
Investigate the route matching logic in app router to understand how multiple routes can match the same path, and devise a method to update core animated pages' selected index so that transitions work correctly.
Tech stack
htmljavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Web ComponentsRouting concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30