erikringsmuth/app-router

core-animated-pages multiple paths match same app-route

Open

#44 opened on Dec 5, 2014

View on GitHub
 (3 comments) (0 reactions) (0 assignees)HTML (608 stars) (83 forks)batch import
bugdesign discussionhelp wanted

Description

This is an extension of PR https://github.com/erikringsmuth/app-router/pull/43 from @sohjsolwin.

Example router.

<app-router core-animated-pages transitions="cross-fade-all">
  <app-route path="/first" element="first-page"></app-route>
  <app-route path="/second" element="second-page"></app-route>
  <app-route path="/page/:pageNum" element="third-page"></app-route>
</app-router>

Paths /page/1 and /page/2 will both match the last route. The transition between these two pages won't be animated because setting coreAnimatedPages.selected = 3 doesn't change the page.

This may require a big re-think of the app-router / core-animated-pages implementation...

Contributor guide

Tech stack
htmljavascriptweb components
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of app router routingFamiliarity with core animated pages
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue describes a problem where multiple routes match the same pattern (e.g., /page/1 and /page/2 both match /page/:pageNum) and the transition between them is not animated because the selected index does not change. This is an extension of PR #43, which likely attempted a fix. To resolve, investigate how app router currently selects the matching route and how core animated pages updates its selected index. Consider a reimplementation that triggers animations even when the route pattern matches but parameters change. The comments and PR #43 may contain attempted solutions.