erikringsmuth/app-router

Hero Transitions

Open

#124 opened on May 20, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)HTML (608 stars) (83 forks)batch import
help wanted

Description

It would seem that the hero-transition attribute does not work I am assuming this is because of the way core-animated-pages selects element (on ShadowRoot level deep).

Any thoughts?

Contributor guide

Tech stack
htmlcssjavascriptweb components
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of web componentsFamiliarity with hero transitions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how core animated pages selects elements at the ShadowRoot level. Check the implementation of the hero transition attribute in the app router and related core animated pages source. Look at existing comments for any identified root cause or workarounds.