Adding FromParams and configuration file pipeline

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

The issue names the FromParams mixin and a configuration file pipeline but does not identify files or tests. Start by reviewing the package's registry and class-instantiation entry points, then compare AllenNLP's FromParams behavior. Done should include an agreed configuration pipeline and corresponding implementation and tests.

Written by the indexing model from the issue text.

Description

The best part about having a registry is that one can write intelligent instantiation logic (once) and not worry about changing that logic as more children classes get added to the code. In order to achieve that, I believe, having the FromParams class in this package will be very useful.

Are you planning to add that? I could take a stab at it as well - do you foresee any issue with adding the FromParams mixin from AllenNLP as is?

Dominant language
Python
Stars
13
Forks
1
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from epwalsh/python-registrable

All issues in epwalsh/python-registrable

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.