enzymejs/enzyme

Shallow(<SomeComponent />).is(SomeComponent) returns false

Open

#768 opened on Jan 12, 2017

View on GitHub
 (14 comments) (0 reactions) (0 assignees)JavaScript (19,979 stars) (2,016 forks)batch import
API: mountbughelp wanted

Description

Basically, this fails:

it('should be true', () => {
  const SomeComponent = () => (<div></div>);
  expect(shallow(<SomeComponent />).is(SomeComponent)).to.be.true;
});

while this works:

  // require('jsdom')...
  it('should be true', () => {
    const SomeComponent = () => (<div></div>);
    expect(mount(<SomeComponent />).is(SomeComponent)).to.be.true;
  });

Am I wrong to assume the first one should work too?

Contributor guide

Tech stack
javascriptreactnodejs
Domain
testingfrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptReactEnzyme
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the shallow renderer's implementation of the `.is()` method, likely in the `shallow.js` or similar file. Compare with the mount renderer's approach. Check the issue comments for any proposed fixes or additional context. The bug appears to be that shallow does not correctly identify the component type for functional components.