enzymejs/enzyme

Silently failing tests with JSDOM

Open

#621 opened on Oct 3, 2016

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,967 forks)batch import
docshelp wanted

Repository metrics

Stars
 (19,826 stars)
PR merge metrics
 (PR metrics pending)

Description

This is likely closely related to #543.

My mocha test suite runs after a setup script.

The problem is that examples fail silently if document.defaultView.XMLHttpRequest is assigned to global.XMLHttpRequest.

Similarly, I worked around it with

if (typeof global[property] === 'undefined' && property !== 'XMLHttpRequest') {
  global[property] = document.defaultView[property];
}

I can't really pinpoint the root cause of this, but if nothing else it may be worthwhile to update the JSDOM guide.

Contributor guide

Research direction
Investigate how JSDOM's XMLHttpRequest assignment affects global scope and causes silent test failures. Examine the guide and consider updating it to warn about this issue.
Tech stack
javascriptreactnodejs
Domain
testingfrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptMochaJSDOM
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55