enzymejs/enzyme

hobgoblin: .html() output for <hr/> differs for shallow() vs. render()

Open

#294 opened on Apr 4, 2016

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (2,016 forks)batch import
help wanted

Repository metrics

Stars
 (19,979 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Testing a minor component that renders only <div><hr /></div>. I was attempting to evaluate testing with outputs from shallow() vs. render() when I found differences in the results from .html().

The shallow renderer's shallowWrapper.html() returns <div><hr/></div>

The static renderer's renderWrapper.html() returns <div><hr></div>

Is static rendering with cheerio causing the strange "how do we represent self-closing elements" differences?

Is there a mention in the docs that nothing is guaranteed about outputs from .html() and .text()?

Is there a stated/doced bias for which renderer to prefer?

Should I tell my consistency hobgoblin to go join the troll under the nearest bridge?

Contributor guide

Research direction
Investigate how shallow renders and static renders handle self closing tags like <hr/>. Look at the enzyme source code for the .html() method in both ShallowWrapper and ReactWrapper (or static renderer). Check if cheerio is used and its handling of self closing elements. Determine if this is a bug or intended behavior due to different underlying renderers.
Tech stack
javascriptreact
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50