enzymejs/enzyme

Upgrading from enzyme-adapter-react-16@1.15.1 -> 1.15.2 breaks connected component tests

Open

#2390 opened on Apr 27, 2020

View on GitHub
 (15 comments) (0 reactions) (0 assignees)JavaScript (19,979 stars) (2,016 forks)batch import
Need To Reproducehelp wantedpackage: react adapter: 16

Description

Current behavior

When I upgrade from 1.15.1 of enzyme-adapter-react-16 to version 1.15.2, I am running into JSX comparison test failures with connected components.

Ex.

  const wrapper = shallow(<SomeComponent />).get(0);
  expect(wrapper).toEqualJSX(
    <ConnectedRouter history={history}>
          ...childrenHere
    </ConnectedRouter>
  )

// FAILURE
- <ConnectFunction
+ <Connect(ConnectedRouterWithContext)

Note: toEqualJSX -> https://www.npmjs.com/package/jasmine-expect-jsx is a simple wrapper around react-element-to-jsx-string -> https://github.com/algolia/react-element-to-jsx-string and turns a react element into a JSX string.

Expected behavior

Expect tests to still pass without change after bumping minor version

Your environment

API

  • shallow
  • mount
  • render

Version

library version
enzyme 3.11.0
react 16.13.1
react-dom 16.13.1
react-test-renderer 16.13.1
adapter (below) 1.15.2

Adapter

  • enzyme-adapter-react-16
  • enzyme-adapter-react-16.3
  • enzyme-adapter-react-16.2
  • enzyme-adapter-react-16.1
  • enzyme-adapter-react-15
  • enzyme-adapter-react-15.4
  • enzyme-adapter-react-14
  • enzyme-adapter-react-13
  • enzyme-adapter-react-helper
  • others ( )

Contributor guide

Tech stack
javascriptreact
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactFamiliarity with enzyme shallow rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the changes between enzyme adapter react 16 versions 1.15.1 and 1.15.2, focusing on display name handling for connected components. The git diff or changelog may reveal modifications in the adapter's rendering logic that altered the component representation from 'ConnectedRouterWithContext' to 'ConnectFunction'. Examining the adapter's source code in the `src/` directory, particularly files related to rendering and component identification, could help identify the exact change.