enzymejs/enzyme

hooks: fix failing tests with mismatched renderer

Open

#2113 opened on Apr 25, 2019

View on GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (19,979 stars) (2,016 forks)batch import
bughelp wantedpackage: react adapter: 16

Description

There's a few tests failing, currently marked as allowed failures in https://github.com/airbnb/enzyme/commit/3db6013d9f5b9034594b78f5c182fc4146af4841, that shouldn't be failing.

Ideally, the functionality can be fixed; if not, then the tests should be skipped when the breakages are expected.

Contributor guide

Tech stack
javascriptreact
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
knowledge of React hooksenzyme testing library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the commit 3db6013d9f5b9034594b78f5c182fc4146af4841 to identify the specific failing tests. Determine whether the failures are due to actual issues with hooks support in enzyme or expected behavior differences. If fixable, update the relevant test files; otherwise, mark tests to skip with appropriate comments. Check the comments in the issue for any additional context or suggested approaches.