enzymejs/enzyme

Create Adapter for React Native & React 16

Open

#1436 opened on Dec 15, 2017

View on GitHub
 (44 comments) (84 reactions) (0 assignees)JavaScript (19,979 stars) (2,016 forks)batch import
feature requesthelp wanted

Description

Problem Statement

Currently we have no support for using a react native adapter with Enzyme. This is because the current adapters are built for react native web.

Attempting to use mount with the current adapter will cause various issues from polluting the user's console with a ton of logs to inability to import necessary libraries.

While this is the case you can get some testing done by filtering the logs and using jsdom.

Most of the console error issues seem to be coming from the ReactDOM call for the React 16 adapter here

Purpose

The purpose of this ticket is to track work related to implementation and decisions regarding implementation of a react native enzyme adapter.

TODO

  1. Find an alternative to rendering with ReactDOM
  2. Decide best way to use the solution for (1) with existing adapters
  3. Decide whether we would like to do all necessary react native stubbing in the adapter a-la react-native-mock-render, do a RYO implementation, or not take a firm stance to the native mocking
  4. Add unit tests to verify functionality
  5. Update Necessary Docs

Related Issues

https://github.com/airbnb/enzyme/issues/1390 https://github.com/airbnb/enzyme/issues/831

Contributor guide

Tech stack
javascriptreact
Domain
testingmobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Enzyme adapter architectureReact Native renderingReact 16JavaScript testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate how the existing React 16 adapter uses ReactDOM (line 173) and explore alternatives like using react test renderer or react native mock render for stubbing. Review the related issues #1390 and #831 for prior discussion on React Native support. Consider implementing a new adapter package similar to enzyme adapter react 16 but tailored for React Native, ensuring unit tests are added and docs updated.