enzymejs/enzyme

React Elements returned by enzyme in v3 are missing context

Open

#1,344 opened on Nov 10, 2017

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (2,016 forks)batch import
API: shallowhelp wantedv3 bugs

Repository metrics

Stars
 (19,979 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In v2, if you wanted to get the underlying element, it contained the element's context. In v3, there is no context.

I believe for shallow, we just need to add it here https://github.com/airbnb/enzyme/blob/master/packages/enzyme-adapter-react-16/src/ReactSixteenAdapter.js#L224

For mount, it's a few places (in those toTree functions).

I think it'd be nice to have the context on the element though so that it's closer to the real element.

Thoughts?

Contributor guide

Research direction
Examine the ReactSixteenAdapter.js file around line 224 and the toTree functions in mount to understand how to add context to the element.
Tech stack
javascriptreact
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReactenzyme
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75