enzymejs/enzyme

Support escaped characters in selectors

Open

#1218 opened on Oct 3, 2017

View on GitHub
 (14 comments) (0 reactions) (0 assignees)JavaScript (19,979 stars) (2,016 forks)batch import
feature requesthelp wanted

Description

Edit from maintainers: this issue was repurposed, see https://github.com/airbnb/enzyme/issues/1218#issuecomment-334489966

Settings

  • React v16
  • Enzyme v3

When i have a component which has a className prop with special character / or @ , it doesnt select anything. I feel enzyme breaks and doesn't continue with the lines after this selector.

Example

const sampleComponent = () => (
    <div className="u-width-1/2@small">
        Something here
    </div>
);

If I have the above component and if I want to select the div containing u-width-1/2@small I tried

const component = shallow(<sampleComponent />);
component.find('.u-width-1/2@small') // This line seems to fail due to error in selector
/* Anything after this doesnt execute */

Contributor guide

Tech stack
javascriptreact
Domain
frontendtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
CSS selector syntaxenzyme library basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue originally requested support for escaped characters in CSS selectors used in enzyme's .find() method. However, maintainers have repurposed this issue (see linked comment #334489966). The current scope is unclear. A contributor should review the comment and discuss with maintainers to determine the new requirements before proceeding.