envoyproxy/xds-relay

Remove ACTIONS_ALLOW_UNSECURE_COMMANDS from github actions

Open

#191 opened on Nov 17, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Go (29 forks)auto 404
good first issue

Repository metrics

Stars
 (135 stars)
PR merge metrics
 (PR metrics pending)

Description

We added ACTIONS_ALLOW_UNSECURE_COMMANDS here, here, here and here to let CI pass. github actions do not allow env variables anymore. We should remove them when possible.

Contributor guide

Research direction
Remove the 'ACTIONS ALLOW UNSECURE COMMANDS: true' lines from the workflow files: .github/workflows/api.yml, common.yml, end2end tests.yml, and integration tests.yml. Then ensure CI passes without this variable.
Tech stack
go
Domain
devopsci cd
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGitHub Actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90