request_body_size is dropped from CommandLineOptions when no request header is configured
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
Start with OptionsImpl::toCommandLineOptions(), where request_options.request_body_size is assigned inside the configured request-header loop. Reproduce with --request-body-size 1234 and --nighthawk-service without --request-header, then verify that the CommandLineOptions proto carries the size and the executed request is no longer empty.
Written by the indexing model from the issue text.
Description
Title: request_body_size is dropped from CommandLineOptions when no request header is configured
Description:
OptionsImpl::toCommandLineOptions() sets request_options.request_body_size inside the loop over the configured request headers, so with --request-body-size N but no --request-header the size is not emitted into the CommandLineOptions proto. Executions routed through the gRPC service (--nighthawk-service) therefore run with an empty body. It should always be emitted.
Reproduction steps:
nighthawk_client --request-body-size 1234 --nighthawk-service <service> http://target/
Compare the executed request body size (0) with a run that also passes any --request-header.
Logs:
No error is logged; the proto simply lacks the field.
Call Stack:
Not a crash.
- Dominant language
- C++
- Stars
- 415
- Forks
- 95
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 11
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from envoyproxy/nighthawk
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
envoyproxy/nighthawk#1605 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
envoyproxy/nighthawk#1609 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
envoyproxy/nighthawk#1608 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
envoyproxy/nighthawk#1607 ·
-
good first issue help wanted tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 30/100
envoyproxy/nighthawk#1367 ·
All issues in envoyproxy/nighthawk
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
infiniflow/infinity#3502 ·