lose watch when SimpleCache respond return false in respondWithSpecificOrder
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- backend-api-design
Research direction
Start in io.envoyproxy.controlplane.cache.SimpleCache and trace respondWithSpecificOrder through respond(watch, snapshot, group). Check how a false return from respond is handled and how the watch lifecycle is updated. Done means an incomplete response does not discard the watch, so the client can rewatch as described.
Written by the indexing model from the issue text.
Description
For ADS mode, class io.envoyproxy.controlplane.cache.SimpleCache will respond to client when setSnapshot.
When respond(watch, snapshot, group); return false, respondWithSpecificOrder will lose the watch, since respond is not complete, client will not rewatch
`
respond(watch, snapshot, group);
// Discard the watch. A new watch will be created for future snapshots once envoy ACKs the response.
return true;
`
- Dominant language
- Java
- Stars
- 312
- Forks
- 150
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from envoyproxy/java-control-plane
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
envoyproxy/java-control-plane#481 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
envoyproxy/java-control-plane#471 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
envoyproxy/java-control-plane#463 ·
-
help Open
Difficulty 4/5 3-5 days Newbie friendliness 25/100
envoyproxy/java-control-plane#432 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
envoyproxy/java-control-plane#411 ·
All issues in envoyproxy/java-control-plane
Similar issues
-
awaiting triage bug Causes friction Hop Gui P1 P2 Transforms
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
apache/flink-agents#1152 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
jenkinsci/blueocean-plugin#5417 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
objectionary/eo-graphs#75 ·