UuidRequestIdConfig Builder

Open
#185 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
api

Research direction

Start with the Java builders for HttpConnectionManager, RequestIDExtension, and the UuidRequestIdConfig referenced in the issue, then compare them with the Envoy uuid.proto definition. Reproduce the TypedStruct error from the example and determine the supported configuration path. Done means documenting or exposing a working way to set pack_trace_reason without the registration error.

Written by the indexing model from the issue text.

Description

We need to be able to set the configuration pack_trace_reason of UuidRequestIdConfig and we didn't find the specific builder.

we try to do this:

HttpConnectionManager.Builder builder = HttpConnectionManager.newBuilder();

builder.setRequestIdExtension(RequestIDExtension.newBuilder()
        .setTypedConfig(Any.pack(TypedStruct.newBuilder()
                .setTypeUrl("type.googleapis.com/envoy.extensions.request_id.uuid.v3.UuidRequestIdConfig")
                .setValue(Struct.newBuilder()
                        .putFields("pack_trace_reason", Value.newBuilder()
                                .setBoolValue(false)
                                .build())
                        .build())
        .build())));

but this create this configuration in envoy:

"request_id_extension": {
	"typed_config": {
	"@type": "type.googleapis.com/udpa.type.v1.TypedStruct",
	"type_url": "type.googleapis.com/envoy.extensions.request_id.uuid.v3.UuidRequestIdConfig",
	"value": {
		"pack_trace_reason": false
		}
	}
}

With this error:

Didn't find a registered implementation for type: 'udpa.type.v1.TypedStruct'

Sorry for the very basic question, but what would be the correct way to configure UuidRequestIdConfig without having a builder?

Dominant language
Java
Stars
312
Forks
150
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from envoyproxy/java-control-plane

All issues in envoyproxy/java-control-plane

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.