envoyproxy/gateway

ReplacePrefixMatch in the URLRewrite filter does not handle empty match prefix correctly

Open

#5,256 opened on Feb 11, 2025

View on GitHub
 (6 comments) (1 reaction) (0 assignees)Go (802 forks)auto 404
help wantedkind/bug

Repository metrics

Stars
 (2,871 stars)
PR merge metrics
 (PR metrics pending)

Description

Description:

In its examples, the Gateway API uses "foo" in "Prefix Match". However, we can conclude that the HTTPPathModifier should also work on / as the path prefix match.

The PR #5254 PR demonstrates that / is not handled correctly.

Repro steps:

Follow the end-2-end test, which is added in #5254

Environment:

In our environment, we use docker.io/envoyproxy/gateway:v1.3.0. The bug is reproducible in the main branch, and is reproducible in v1.2.5

Contributor guide

Research direction
Inspect the e2e test added in PR #5254 and trace the URLRewrite filter's ReplacePrefixMatch handler to understand why it fails for empty match prefix path.
Tech stack
go
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65