envoyproxy/gateway

EG does not cleanup Envoy proxy deployments if a gateway delete notification is missed

Open

#4,792 opened on Nov 27, 2024

View on GitHub
 (11 comments) (1 reaction) (1 assignee)Go (802 forks)auto 404
help wanted

Repository metrics

Stars
 (2,871 stars)
PR merge metrics
 (PR metrics pending)

Description

Description: The issue observed is that orphaned Envoy proxy deployments are not removed when a gateway delete notification is missed.

It is expected that during a full reconcile, EG can identify and clean up these orphaned proxies to maintain consistency and prevent resource leakage. finalizers are missing.

Repro steps: 1. Create a gateway and observe that the Envoy proxy deployment is created successfully. 2. Scale EG to 0 and delete the gateway resource 3. Scale EG back to 1 to force a full reconcile 4. Observe that the orphaned Envoy proxy deployment is not removed.

Contributor guide

Research direction
Investigate the reconciliation logic in the gateway controller to ensure that orphaned Envoy proxy deployments are properly cleaned up during full reconciliation. Look for missing finalizers and handle missed delete notifications.
Tech stack
go
Domain
infrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
KubernetesGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60