envoyproxy/gateway

Merge gateway EnvoyProxy parameters between the class and gateway instance

Open

#3,944 opened on Jul 23, 2024

View on GitHub
 (12 comments) (5 reactions) (0 assignees)Go (802 forks)auto 404
help wanted

Repository metrics

Stars
 (2,871 stars)
PR merge metrics
 (PR metrics pending)

Description

Description: When using a set of EnvoyProxy parameters at the gateway class level with spec.parametersRef and a separate set of parameters at the gateway level with spec.infrastructure.parametersRef, it would be nice if the configuration was merged and the gateway parameters override the gateway class parameters. For example, I want to setup the gateway class to set a default replica count of two and a PDB with minAvailable=1 for all my gateways and setup my gateways with specific loadBalancerIPs.

The Gateway API does call this feature out as implementation specific and includes a recommendation for this support but through testing of Envoy Gateway v1.1.0 gateway instance parameters seem to override all gateway class parameters.

Relevant Links: https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io/v1.GatewayClassSpec https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io/v1.GatewayInfrastructure

Contributor guide

Research direction
Investigate the current merging logic for EnvoyProxy parameters between gateway class and gateway instance. Refer to the Gateway API specification for the recommended merge strategy. Implement a merge that allows gateway instance parameters to override class parameters while combining non conflicting settings.
Tech stack
gokubernetes
Domain
backendinfrastructureapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GoKubernetesEnvoy Gateway
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30