envoyproxy/envoy

SSL Connection: combine SSL_set_ex_data and SSL_set_app_data

Open

#9,867 opened on Jan 29, 2020

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/tlshelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Combine SSL Connection's SSL_set_ex_data and SSL_set_app_data

Description: PR #9172 introduces additional SSL_set_ex_data to be able to update SslExtendedSocketInfo during SSL validation. This issue is to refactor the new SSL_set_ex_data and existing SSL_set_app_data to combine to a single SSL_set_app_data.

Currently: SSL_set_app_data: The ContextImpl's const Network::TransportSocketOptions* options set by the ContextImpl but only if (options && !options->verifySubjectAltNameListOverride().empty()) when the SslSocket is created SSL_set_ex_data: The SslSocketInfo::SslExtendedSocketInfo member set when the SslSocket is subsequently moved to be owned by the constructed SslSocketInfo

Contributor guide

Research direction
Inspect the existing usage of SSL set ex data and SSL set app data in the codebase, particularly in SslSocket construction and ContextImpl. Trace how options and extended info are set, then refactor to use only SSL set app data with a combined structure.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40