envoyproxy/envoy

Envoy should register invalid HTTP as an attempt to send a request

Open

#9,821 opened on Jan 24, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/httphelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Envoy should register invalid HTTP as an attempt to send a request

Description: If a malformed HTTP1 request is sent (e.g. No headers, just "a\r\n\r\n") the HTTP1.1 code will reject it (https://github.com/envoyproxy/envoy/blob/master/source/common/http/http1/codec_impl.cc#L497) and send a 400 without creating a ConnectionManagerImpl::ActiveStream. This means that the stats around total requests (downstream_rq_total_ & similar) will not be modified, as they are modified by ConnectionManagerImpl::ActiveStream. It seems like an invalid request should still be counted in those statistics.

Contributor guide

Research direction
Locate where invalid HTTP requests are rejected in the HTTP/1.1 codec, and ensure that the downstream rq total counter is incremented before sending the 400 response.
Tech stack
cpp
Domain
backendobservability
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++HTTP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55