envoyproxy/envoy

/reset_counter does not reset host statistics

Open

#9,819 opened on Jan 24, 2020

View on GitHub
 (3 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/statshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: /reset_counter does not reset host statistics

Description: During troubleshooting if someone collects statistics from "/stats" and from "/clusters" then the output may show difference if "/reset_counter" was used beforehand.

It seems so that "/reset_counter" does not reset the host statistics.

It is desirable to keep those stats in sync.

Contributor guide

Research direction
Examine the /reset counter endpoint implementation and trace how host statistics are reset; compare with cluster statistics reset to find the discrepancy.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55