envoyproxy/envoy

feature request: `skip_if_present` for request/response headers to add

Open

#9,525 opened on Dec 30, 2019

View on GitHub
 (5 comments) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
area/httphelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: skip_if_present for request/response headers to add

Description: When using request/response_headers_to_add, the only options are either replace the header or append to it. Sometimes it may be preferable to simply ignore if the header is already set. This would add a boolean skip_if_present option to core.HeaderValueOption that defaults to false.

Contributor guide

Research direction
Examine the core.HeaderValueOption protobuf definition and the header addition logic in source/common/router/header parser.cc. Add a bool skip if present field with default false, then implement logic in the request/response header addition path to skip if the header already exists and skip if present is true.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++ProtobufBazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65