envoyproxy/envoy

access log: file access log memory growth between flush events

Open

#9,458 opened on Dec 23, 2019

View on GitHub
 (1 comment) (3 reactions) (0 assignees)C++ (5,373 forks)batch import
area/perfhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

with high throughput, the file access log flush can accumulate many events and cause excessive memory consumption. Currently it flushes every time interval or 64KB (which ever is sooner). we should consider making this tunable, or add other mechanism (adaptive interval?) to help limit memory consumption.

Contributor guide

Research direction
Inspect the current file access log flush mechanism in source/common/access log/file access log impl.h and propose a configuration option to control the flush threshold (e.g., number of events or buffer size).
Tech stack
cpp
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20