envoyproxy/envoy

adaptive concurrency: Allow specification of runtime names

Open

#8,638 opened on Oct 17, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

As a prerequisite to supporting both egress and ingress adaptive concurrency, it will be necessary to specify the runtime configuration names to avoid conflicts. Before declaring the filter production ready, the adaptive concurrency configuration parameters should be replaced by their runtime counterparts.

To be more specific for anyone who gets to this before I do, we want to change any parameters in the adaptive_concurrency.proto that correspond to any of the runtime options that override them. For example, changing parameters in the proto from Uint32 to RuntimeUInt32.

Contributor guide

Research direction
Study the adaptive concurrency.proto and corresponding runtime options. Identify parameters that have runtime overrides (e.g., minRtt, sampleAggregatePercentile) and change their types from UInt32 to RuntimeUInt32. Update the filter implementation to read from runtime values when available.
Tech stack
cpp
Domain
backendnetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++ProtobufEnvoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30