envoyproxy/envoy

Use StringMatcher for route path and header matching

Open

#8,392 opened on Sep 26, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
api/v3help wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

As per #next-major-version comments in https://github.com/envoyproxy/envoy/blob/master/api/envoy/api/v2/route/route.proto. We should ideally do this in v2 with new fields and then deprecate the existing matchers, allowing for auto-deletion in v3.

Contributor guide

Research direction
Examine the route.proto file referenced in the issue, identify the existing regex string matchers, and add new StringMatcher fields for path and header matching. Deprecate the old fields. Ensure compatibility with v2 and plan for v3 removal. Test the changes.
Tech stack
cpp
Domain
backendnetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65