envoyproxy/envoy

Better control on xDS deduplication based on protobuf

Open

#8,301 opened on Sep 19, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
api/v3design proposalhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

From discussion in https://github.com/envoyproxy/envoy/pull/8231#discussion_r324191998

Key take aways:

  • Prefer using version_info instead comparing new xDS delivered config with existing one, this also solves https://github.com/envoyproxy/envoy/issues/7676

  • Add a UUID in ConfigSource for deduplication, instead of hashing ConfigSource proto to automatically dedup. This means RDS/SDS ConfigSource sent from LDS should be deduplicated at control plane.

Contributor guide

Research direction
Investigate how xDS deduplication is currently implemented in Envoy, understand the version info and UUID approach proposed in the issue, and propose an implementation plan.
Tech stack
cpp
Domain
backendinfrastructureapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC++ProtobufEnvoy architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30