envoyproxy/envoy

Setting runtime fraction of numerator 0 and FractionalPercent_HUNDRED for RequestMirrorPolicy ends up using FractionalPercent_THOUSAND

Open

#8,299 opened on Sep 19, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
bughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Setting runtime fraction of numerator 0 and FractionalPercent_HUNDRED for RequestMirrorPolicy ends up using FractionalPercent_THOUSAND

Description: We are rolling our RequestMirrorPolicy, we set the path within the Runtime Fraction but not the default like so:

RuntimeFraction: &core.RuntimeFractionalPercent{
    RuntimeKey: policy.RuntimeKey,
    DefaultValue: &envoytype.FractionalPercent{
      Numerator:   0,
      Denominator: envoytype.FractionalPercent_HUNDRED,
    },
},

But as I change the runtime flag, I am noticing that the runtime fraction is using FractionalPercent_TEN_THOUSAND as a denominator based on the aggregated stats.

Since envoytype.FractionalPercent_HUNDRED is the default value, I believe envoy is treating DefaultValue as a nil value and exercising this code path: https://github.com/envoyproxy/data-plane-api/blob/master/envoy/api/v2/route/route.proto#L640-L645

Contributor guide

Research direction
Investigate the runtime fraction default handling in Envoy's request mirror policy. Trace the code path when DefaultValue's numerator is 0 and denominator is HUNDRED to understand why it falls back to TEN THOUSAND.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GoC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50