envoyproxy/envoy

Refactor outlier detection configuration fields

Open

#8,219 opened on Sep 11, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
api/v3help wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Refactor outlier detection config message fields

Description: As discussed in https://github.com/envoyproxy/envoy/pull/8130#discussion_r320832679, the outlier detection configuration fields are a bit messy and could use a cleanup. The main work here is to de-dup all of the options into a common message around enabled, local origin split, etc. and then hopefully just have a single field per actual ejection type. This would avoid an explosion of almost identical fields for each different ejection type.

Contributor guide

Research direction
Study the existing outlier detection configuration messages in the Envoy source code, focusing on the discussion in PR #8130. Understand the duplication among fields for different ejection types and propose a unified structure with common fields such as `enabled`, `local origin split`, etc. Plan to create a common message and then have a single field per ejection type.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Envoy architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50