envoyproxy/envoy

CORS. Dynamic set access-control-allow-headers from access-control-request-headers

Open

#8,218 opened on Sep 11, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Feature request. Set access-control-allow-headers dynamically from access-control-request-headers with rule

Description:

Now cors filter set response header access-control-allow-headers to allow_headers value from config. Wildcard not support/work in access-control-allow-headers in browser if access-control-request-headers set in request. Best practice resolve this problem, set access-control-allow-headers to value access-control-request-headers if wildcard in config.

Will this implement in envoy? Thanks.

Contributor guide

Research direction
Implement dynamic setting of Access Control Allow Headers based on Access Control Request Headers when wildcard is configured in CORS filter.
Tech stack
cpp
Domain
backendapinetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55