envoyproxy/envoy

Make wrapped / native scalar types consistent in v4 API

Open

#8,128 opened on Sep 3, 2019

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
api/v4help wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (PR metrics pending)

Description

In v2, we started of by wrapping everything, but then settled on a policy of only wrapping scalar fields that have non-proto3 defaults. There is a legacy of this across the API that should be cleaned up to be more consistent, v3 is such an opportunity.

Contributor guide

Research direction
Study the current policy on wrapping scalar fields with non proto3 defaults, then audit the API for inconsistencies and propose a consistent approach.
Tech stack
cpp
Domain
apibackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
GitC++Protobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45