envoyproxy/envoy

perf: make dispatcher loop stats work with statsd

Open

#8,109 opened on Aug 30, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/perfarea/statshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

I've been debugging a perf problem at Lyft and the dispatcher loop stats are indeed incredibly useful. We should make these stats usable with statsd. The best way I can see to do this is to potentially have the ability to tag a histogram as "high rate" so that it gets ignored by statsd for individual flushes, and then statsd could potentially flush high rate histograms as gauges with various percentiles dumped?

Contributor guide

Research direction
Investigate how dispatcher loop stats are currently implemented and how they are flushed. Then understand the statsd sink in Envoy and propose a way to tag high rate histograms so that statsd can flush them as gauges with percentiles.
Tech stack
None
Domain
observability
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60