envoyproxy/envoy

eds: envoy is sending EDS discovery request without any resource_names set

Open

#7,529 opened on Jul 11, 2019

View on GitHub
 (59 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
bughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Envoy is sending EDS discovery request without any resource_names set

Description: Lyft has noticed envoy requesting EDS data without resouce_names set. It is sporadic throughout all services. This is happening enough where our control plane started to page (as our control plane treats this request as an error).

We noticed that the envoy discovery request payload always has a version set and a response_nonce set. So Envoy does have historical EDS data, thus didn't notice any degradation in the data plane.

Logs: Here is a sample request payload coming from our control plane logs.

{
  "version_info": "6682668b14343e6a63e29e538a9839dfb46c647d",
  "node": {
    "id": "06699ec750c498729",
    "cluster": "roadspinned-production-iad",
    "locality": {
      "zone": "us-east-1f"
    },
    "build_version": "7e8f440546bd920c2468b0e379798a79547ca2ca/1.11.0-dev/Modified/RELEASE/BoringSSL"
  },
  "type_url": "type.googleapis.com/envoy.api.v2.ClusterLoadAssignment",
  "response_nonce": "36"
}

Contributor guide