envoyproxy/envoy

To add LocalInfoFormatter and LocalInfoHeaderFormatter

Open

#7,213 opened on Jun 8, 2019

View on GitHub
 (0 comments) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

To add LocalInfoFormatter and LocalInfoHeaderFormatter.

Description: Currently seems like there is no way to log information holds by LocalInfo while the information is sometimes useful and also to utilize that information as values in e.g. response_headers_to_add, request_headers_to_add.

Probably adding LocalInfoHeaderFormatter and LocalInfoFormatter in header formatter and access log formatter respectively will help.

@zuercher WDYT?

Contributor guide

Research direction
Examine existing formatter implementations like RequestInfoHeaderFormatter and AccessLogFormatter to understand the pattern, then implement LocalInfoFormatter and LocalInfoHeaderFormatter to expose LocalInfo fields.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy proxy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30