envoyproxy/envoy

Audit absl::flat_hash_map usage

Open

#7,162 opened on Jun 4, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
help wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Description: https://github.com/envoyproxy/envoy/pull/7146#issuecomment-498506399

We should audit all flat_hash_map usage and see if this could occur in other places, this is not easy to catch in our CI tests. Not sure whether absl provides a good way to test things like this.

Contributor guide

Research direction
Audit all uses of absl::flat hash map in the Envoy codebase to identify potential issues similar to those described in the linked PR comment. Check for correctness and testability.
Tech stack
cpp
Domain
backend
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30