envoyproxy/envoy

HeaderMap: C string to string_view conversion follow ups

Open

#6,580 opened on Apr 15, 2019

View on GitHub
 (16 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/securityhelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Description:

These are various places where we need to follow up to complete removal of C style strings in the header map.

  1. HeaderString::find(const char* str) can probably be eliminated entirely by converting call sites to use getStringView().find().
  2. StringUtil::atoull currently requires creation of some temporary std::string objects because it expects C strings, and also returns a C style string. Most call sites ignore the return value, so they can be converted to use absl::SimpleAtoi or a new StringUtil function that takes and returns string views.
  3. UuidUtils::uuidModBy() should be migrated to take absl::string_view
  4. Span::setOperation() should be migrated to take absl::string_view

Context: https://github.com/envoyproxy/envoy/issues/6494 https://github.com/envoyproxy/envoy/pull/6564

Action item for CVE-2019-9900

Contributor guide

Research direction
Review the linked PR #6564 and issue #6494 for context. For each item: (1) Search for HeaderString::find calls and replace with getStringView().find(). (2) Update StringUtil::atoull and its call sites to use absl::SimpleAtoi. (3) Migrate UuidUtils::uuidModBy to use absl::string view. (4) Migrate Span::setOperation to use absl::string view. Write tests to verify no regressions.
Tech stack
cpp
Domain
backendsecurity
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65