envoyproxy/envoy

Add response flags to requests metrics

Open

#6,431 opened on Mar 29, 2019

View on GitHub
 (8 comments) (13 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Add response flags to request metrics

Description: Request metrics take the form of envoy_cluster_upstream_rq{envoy_response_code="503",envoy_cluster_name="<cluster_name>"} in the /stats?format=prometheus endpoint. In the access logs, each log line can be configured to include the response_flags associated with Envoy's response. Adding the response_flags that are present in the access log to these metrics would help disambiguate this data and help more quickly determine root causes.

Contributor guide

Research direction
Examine how current request metrics are emitted in Envoy's stats and how response flags are added in access logs. Then extend the metrics to include response flags as a label.
Tech stack
cpp
Domain
observability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40