envoyproxy/envoy

Consider default TCP keep alive for xDS connections

Open

#6,323 opened on Mar 19, 2019

View on GitHub
 (13 comments) (3 reactions) (0 assignees)C++ (5,373 forks)batch import
design proposalhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Related to https://github.com/envoyproxy/envoy/issues/5173. I've been thinking about this, and I think we should consider having default TCP keep alive settings for xDS connections, with maybe an option to fully disable if it's not wanted.

I think this issue is going to hit almost everyone and we can have a better OOB experience.

Thoughts @suhailpatel @htuch @fredlas?

Contributor guide

Research direction
Explore the xDS client code in Envoy to understand current TCP socket options and determine where to add default keep alive settings. Look at the referenced issue #5173 for context.
Tech stack
cpp
Domain
backendnetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++network programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60