envoyproxy/envoy

Allow option to not emit statsd metrics when reporting a `0` value

Open

#6,205 opened on Mar 7, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

We store the statsd metrics envoy emits in a SAAS monitoring tool that charges us based on the number of measurements we store at a particular reporting interval. Some of the metrics we are recording are consistently 0, with occasional spikes when something happens. Here's an example:

image 2019-03-07 at 11 54 16 am

I can see the value in using a 0 value to report "nothing is happening", but our monitoring bill has doubled as a result of adopting envoy(!), and continues to grow as we add more clusters, so we'd like to save some money by not recording measurements we can mostly infer from an absence of data.

That said, the zero values were very helpful when were spiking into adopting envoy, as it allowed us to see which metrics we could expect from envoy. Maybe this should be a configuration option in the StatsMatcher proto?

Contributor guide

Research direction
Investigate the StatsMatcher proto and follow the stats emission path to add a configuration option to suppress zero value metrics.
Tech stack
cpp
Domain
observability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30