envoyproxy/envoy

redis proxy: add access log

Open

#6,138 opened on Mar 1, 2019

View on GitHub
 (7 comments) (11 reactions) (0 assignees)C++ (5,373 forks)batch import
area/access_logenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Access log not available for redis proxy filter

Description: TCP proxy filter has access log which is useful for debugging. redis proxy however, does not have this field to configure. In a debugging senario, I have to changed to redis proxy to tcp proxy to verify traffic go through envoy.

[optional Relevant Links:]

I'm not so sure the appropriate way to debug the case above and if access log makes sense for networking filter or not. Please feel free to point something that's intended to be used instead.

Contributor guide

Research direction
Study the TCP proxy access log implementation in Envoy and apply similar pattern to the redis proxy filter. Modify the redis proxy proto to add access log configuration and implement logging in the filter code.
Tech stack
cpp
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy proxy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40