envoyproxy/envoy

add computed-timeout field to structured access log

Open

#6,121 opened on Feb 28, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Emitting a field in the structured access log with the computed timeout for a request would be useful. Given a set of access logs with this information, it would be easy to identify the nature of requests that are generally in danger of timing out. Since timeouts can be dynamic on a per-request basis, it is difficult to determine this from an access log that only contains the final request latency.

Contributor guide

Research direction
Study the structured access log format in Envoy, identify where computed timeout is calculated in the request lifecycle, and modify the log formatter to include that field.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy internalsAccess log format
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35