envoyproxy/envoy

tap: gRPC body matching

Open

#6,109 opened on Feb 27, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/taphelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Allow matching on gRPC message fields.

  1. Allow loading descriptor files into the tap filter, similar to how the transcoder works.
  2. Using reflection, allow parsing gRPC messages up to a buffer limit (can also work with streaming messages potentially).
  3. Via field selection and a TBD matching language, allow matching on individual fields/messages using only loaded descriptor data / reflection.

See https://github.com/envoyproxy/envoy/issues/6108 for JSON matching. It's possible this can be used for that if we consider JSON a Struct.

Contributor guide

Research direction
Investigate the existing tap filter implementation, study how the transcoder loads descriptor files, and understand gRPC reflection for parsing messages. Then design a field selection and matching language for gRPC body matching.
Tech stack
cppgrpc
Domain
backendnetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++GitgRPCprotobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25