envoyproxy/envoy

Unexpected metric names when cluster name contains dot

Open

#5,239 opened on Dec 6, 2018

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
bughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Unexpected metric names when cluster name contains dot

Description:

When cluster name contains dot, cluster-specific metric names are unexpected.

Repro steps:

Create a cluster with dots in its name, e.g. foo.example.com, and then look for cluster metrics like envoy.cluster.upstream_rq_xx

Expected:

The metric should be named envoy.cluster.upstream_rq_xx with tag envoy_cluster_name=foo.example.com

Actual:

The metric is named envoy.cluster.example.com.upstream_rq_xx with tag envoy_cluster_name=foo

Contributor guide

Research direction
Investigate the metric naming code in Envoy, specifically how cluster names with dots are parsed. Trace the logic that splits cluster name on dots and reconstructs the metric name.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Envoy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40