envoyproxy/envoy

Add ability to configure TLS session cache key

Open

#5,073 opened on Nov 16, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Add ability to configure TLS session cache key, so that sessions stored in ClientContextImpl can be retrieved by a specific key(s) (e.g. %UPSTREAM_CLUSTER% - which is effectively what we have right now, %UPSTREAM_HOST% or %REQ(:AUTHORITY)%).

See https://github.com/envoyproxy/envoy/issues/3817 and https://github.com/envoyproxy/envoy/pull/4791 for some background.

Contributor guide

Research direction
Familiarize yourself with the TLS session cache in Envoy's ClientContextImpl. Study how the cache key is currently derived (e.g., using UPSTREAM CLUSTER). Then design a configuration option to allow users to set custom cache key components like UPSTREAM HOST or REQ(:AUTHORITY). Review the linked issue #3817 and PR #4791 for context.
Tech stack
cpp
Domain
backendsecurity
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Bazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25