envoyproxy/envoy

Reduce boilerplate and enforce InSequence in RouterTest

Open

#4,916 opened on Oct 30, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
help wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

The tests in RouterTest (test/common/router/router_test.cc) are very verbose and hard to work with. We should 1) reduce the amount of boilerplate necessary and 2) use InSequence in every test.

Contributor guide

Research direction
Familiarize yourself with the existing RouterTest setup, study how InSequence is used in other tests, and identify boilerplate patterns that can be abstracted or removed.
Tech stack
cpp
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Google TestBazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65