envoyproxy/envoy

Clean up tests that start an admin HTTP server just to get by

Open

#4,531 opened on Sep 25, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
help wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

After #4486 is submitted, it will be possible to create an instance of the Admin admin console class without automatically starting an HTTP listener. Tests that specify an admin address in a bootstrap config - and so start an HTTP listener - just to get through startup correctly can now have that listening address removed. At least one example (I think?) is in test/config/utility.cc, ConfigHelper constructor.

Contributor guide

Research direction
Examine the test configuration in test/config/utility.cc and identify tests that specify an admin address solely to pass startup. Remove the admin address from those tests after verifying that the Admin console class can be instantiated without an HTTP listener.
Tech stack
cpp
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70