envoyproxy/envoy

Add filter_enabled flag to RBAC filter

Open

#38,435 opened on Feb 12, 2025

View on GitHub
 (4 comments) (2 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Add filter_enabled flag to RBAC filter

Description: Currently, Envoy's RBAC filter does not have a filter_enabled field that other http filters have (e.g. localRateLimit and extAuth). Adding this flag to the RBAC filter would provide flexibility in enabling or disabling the filter at runtime based on runtime settings allowing for dynamic management of filter behavior without requiring a full configuration deployment.

I can prepare a patch for this if it sounds reasonable.

Contributor guide

Research direction
Study the existing filter enabled implementation in other HTTP filters like localRateLimit and extAuth. Then replicate the pattern for RBAC filter. Focus on the proto definition, runtime integration, and filter logic to enable/disable based on runtime key.
Tech stack
cpp
Domain
backendnetworkingapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++EnvoyProtocol Buffers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50