envoyproxy/envoy

Add an option to shutdown when connections reach zero

Open

#3,837 opened on Jul 10, 2018

View on GitHub
 (19 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Description: For graceful shutdown scenarios described in #1990 we largely have what we need, but it would be extra helpful to allow envoy to exit once ingress connections reach zero.

Basically if we have a service that wants to:

  1. Use envoy for ingress and egress
  2. Has a potentially long and highly variable drain time (e.g. 5 min to 4 hours)

It would be nice if we could have a sigterm:

  1. unbind from ingress ports and begin draining the connections.
  2. leave egress open for any inflight requests Note: #1 and #2 are already supported
  3. Once all of the ingress (or all!) connections have closed then have envoy exit.

Relevant Links: https://github.com/envoyproxy/envoy/issues/1990

Contributor guide

Research direction
Investigate the existing graceful shutdown mechanisms in Envoy, particularly the drain manager and connection handling. Review issue #1990 for context. Look at how ingress and egress connections are tracked and how the shutdown sequence works. Then propose an option to trigger exit when all ingress connections have closed.
Tech stack
cpp
Domain
backendnetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55